Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use µs not us #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use µs not us #42

wants to merge 2 commits into from

Conversation

RobertGauld
Copy link

At the risk of starting a debate µ (not u) is the correct SI prefix for micro.

I've deliberatly split the PR into 2 commits incase you want to support parsing but not generating the correct micro prefix.

@RobertGauld RobertGauld marked this pull request as draft September 25, 2023 10:09
@RobertGauld RobertGauld marked this pull request as ready for review September 25, 2023 10:09
@ptdecker
Copy link

ptdecker commented Oct 4, 2023

If this is added, can it be done as a feature switch? I have a very significant corporate customer (a large global financial institution) who has dinged us (a small start up) for delivering logs that contain µ. I'm using this in a CLI application because it is so awesome but if it starts outputting the unicode symbol again they will freak out. Thank you for considering the welfare of your fellow coders! ;-)

@RobertGauld RobertGauld mentioned this pull request Oct 6, 2023
@RobertGauld
Copy link
Author

Thanks @ptdecker, that suggestion's in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants