Readme updates #6
Conversation
README.md
Outdated
| @@ -31,23 +31,20 @@ This module was originally written by [Jadestorm](https://github.com/jadestorm/) | |||
|
|
|||
| The patroni module sets up the following: | |||
|
|
|||
| * Installs Patroni via package manager | |||
| * Install necessary PostgreSQL packages | |||
| * Installs Patroni via Pip | |||
|
We don't need the postgres stuff anymore in the README? Perhaps a link to https://github.com/tailored-automation/puppet-module-patroni/blob/master/examples/patroni.pp that shows it in context with postgres. |
|
The postgres things are entirely handled by the manifest code so doing things managing postrgresql outside this module are not recommended since all we really need to do is install the appropriate package so that aspect is handled inside this module. The way Patroni works is it manages the entire PostgreSQL stack so doesn't make sense to put such logic into profile class since it's a core part of patroni. I'm not sure linking to the code is a good idea as the only way it would be useful is to link to specific lines of code that are relevant and those lines could change and make the links point to the wrong lines and thus make the links not useful or confusing. |
No description provided.