Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest long URL for new go links if peer exists #115

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

willnorris
Copy link
Member

@willnorris willnorris commented Mar 15, 2024

If you visit a non-existent go link, we render the home page and pre- populate the "short" input with the name of the link, and autofocus the "long" input so that you can simply paste a long URL and submit.

It is common (at least at Tailscale) to create go links that correspond to the name of a device on the tailnet. For example, go/who points to http://who/. With this change, when you visit a non-existent go link, we check to see if a peer exists on the tailnet with that name, and if so we suggest that as the long URL.

Example:
Screenshot 2024-03-15 at 11 48 18 AM

If you visit a non-existent go link, we render the home page and pre-
populate the "short" input with the name of the link, and autofocus the
"long" input so that you can simply paste a long URL and submit.

It is common (at least at Tailscale) to create go links that correspond
to the name of a device on the tailnet.  For example, go/who points to
http://who/.  With this change, when you visit a non-existent go link,
we check to see if a peer exists on the tailnet with that name, and if
so we suggest that as the long URL.

Signed-off-by: Will Norris <[email protected]>
Copy link

@catzkorn catzkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@willnorris willnorris merged commit 6c79b50 into main Mar 15, 2024
4 checks passed
@willnorris willnorris deleted the will/suggest branch March 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants