add support for golink peer capability #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnorris
force-pushed
the
will/caps
branch
2 times, most recently
from
01bde74
to
c8c2f80
Compare
Technically, this is one commit before the 1.52.0 tag to keep it a pseudo-version. Signed-off-by: Will Norris <[email protected]>
creachadair
reviewed
Oct 31, 2023
golink.go
Outdated
| caps, _ := tailcfg.UnmarshalCapJSON[capabilities](whois.CapMap, peerCapName) | ||
| for _, cap := range caps { | ||
| if cap.Admin { | ||
| u.isAdmin = true |
There was a problem hiding this comment.
Could we not at this point return directly? Then we don't really need named results:
login := whois.UserProfile.LoginName
// ...
for _, cap := range caps {
if cap.Admin {
return user{login: login, isAdmin: true}, nil
}
}
return user{login: login}, nilor words to that effect?
The "tailscale.com/golink" peercap includes a single "admin" bool field. When set, this grants the user the ability to edit all links stored in the system. Update currentUser to return a simple user struct instead of just a bare username. Rename checkLinkOwnership to canEditLink and change to a bool return value. Signed-off-by: Will Norris <[email protected]>
creachadair
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "tailscale.com/golink" peercap includes a single "admin" bool field. When set, this grants the user the ability to edit all links stored in the system.
Update currentUser to return a simple user struct instead of just a bare username. Rename checkLinkOwnership to canEditLink and change to a bool return value.
I gather that "domain/path" is the new preferred naming convention for peercaps? If not, let me know. I also debated a little on whether to have a single admin value or something more complicated like access levels, matching link names with
*allowing access to all links, etc. But I have trouble imagining non-contrived use cases for anything beyond a simple admin role.