-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default tag from div
to Fragment
on Transition
components
#3110
Merged
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee252b3 - Browse repository at this point
Copy the full SHA ee252b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9b37d2 - Browse repository at this point
Copy the full SHA c9b37d2View commit details -
only error on missing
ref
if it's actually requiredIf the `<Transition />` component "root" is used as a root placeholder (for state management) and not making actual transitions itself, then we don't require a `ref` element.
Configuration menu - View commit details
-
Copy full SHA for 2b59749 - Browse repository at this point
Copy the full SHA 2b59749View commit details -
add test to ensure we don't error on missing
ref
when not required+ add `className="…"` to some places to indicate that we _do_ want to perform a transition and thus have to fail if the `ref` is missing.
Configuration menu - View commit details
-
Copy full SHA for 58725bc - Browse repository at this point
Copy the full SHA 58725bcView commit details -
Also ensure that a ref is required if the `as` prop is provided and it's not a `Fragment`
Configuration menu - View commit details
-
Copy full SHA for dea822b - Browse repository at this point
Copy the full SHA dea822bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 312a52c - Browse repository at this point
Copy the full SHA 312a52cView commit details -
These tests were rendering a `Debug` element that didn't render any DOM nodes. Adding `as="div"` ensures that we are forwarding the ref correctly.
Configuration menu - View commit details
-
Copy full SHA for 3970e64 - Browse repository at this point
Copy the full SHA 3970e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bdb4cc - Browse repository at this point
Copy the full SHA 5bdb4ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99698a4 - Browse repository at this point
Copy the full SHA 99698a4View commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7fced21 - Browse repository at this point
Copy the full SHA 7fced21View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.