Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tabbing to a portalled <PopoverPanel> component moves focus inside (without using <PortalGroup>) #3239

Merged
merged 3 commits into from
May 24, 2024
Merged

Ensure tabbing to a portalled <PopoverPanel> component moves focus inside (without using <PortalGroup>) #3239

merged 3 commits into from
May 24, 2024

Commits on May 24, 2024

  1. ensure we allow focus in the focus sentinel button 

    We already checked this button when inside of a `PopoverGroup`, but we
didn't when you weren't using a `PopoverGroup` component.
    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8d29ee6 View commit details
    Browse the repository at this point in the history

  2. add test

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    bd29ef8 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    778cc93 View commit details
    Browse the repository at this point in the history