-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order utilities clockwise where applicable #10947
Conversation
src/corePlugins.js
Outdated
[['end', ['inset-inline-end']]], | ||
[['bottom', ['bottom']]], | ||
[['left', ['left']]], | ||
[['start', ['inset-inline-start']]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should keep start
and end
as-is? This change would sort it end
first then start
which seems odd? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Yo @adamwathan what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda second guessing some of this a bit, I think I would hate for |
A different approach could be to sort from
and
(or, similarly, y-axis grouping followed by x-axis grouping). |
👋 @thecrypticace, what is the current status of this PR? Happy to help with testing, if needed! Poll results above make sense actually, so the order does not have to be clockwise. |
I'll re-open this PR once we've worked through the decisions we want to make here. |
Fixes tailwindlabs/prettier-plugin-tailwindcss#147
We're gonna change things so the appropriate
inset
,padding
,margin
, etc… utilities are in a clockwise sort order.