Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RegEx parser, reduce possibilities as the key for arbitrary properties #12121

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Improve RegEx parser, reduce possibilities as the key for arbitrary properties #12121

merged 5 commits into from
Oct 2, 2023

Commits on Oct 2, 2023

  1. optimize handling of RegEx parser results 

    Previous:
- Copy `results`, for every subsequent result of other `patterns`
- Loop over results to filter out `undefined` values
- Loop over results to map to `clipAtBalancedParens`

Current:
- For each candidate, push the `clipAtBalancedParens(candidate)` into
  the `results`

This way we are not copying existing results, and we are also avoiding
additional loops over the entire array to filter out `undefined` values
and map to `clipAtBalancedParens`.
    @RobinMalfait
    RobinMalfait committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    468c66a View commit details
    Browse the repository at this point in the history

  2. do not allow ] in the first part of arbitrary properties 

    ```
[foo:bar]
 ─┬─
  └── This part cannot contain `]`
```

This is also a very targeted fix for when the arbitrary properties seem
to match a large piece of text, but shouldn't
    @RobinMalfait
    RobinMalfait committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e6963fa View commit details
    Browse the repository at this point in the history

  3. add real world tests for parsing candidate strings

    @RobinMalfait
    RobinMalfait committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7aa35a6 View commit details
    Browse the repository at this point in the history

  4. sync package-lock.json

    @RobinMalfait
    RobinMalfait committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    5be5f02 View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e0d8924 View commit details
    Browse the repository at this point in the history