Enable Vite's waitForRequestsIdle() for client requests only
#13394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
waitForRequestsIdle but only when not doing SSRwaitForRequestsIdle() for client requests only
adamwathan
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
waitForRequestsIdle()API should not be called when doing SSR as it was not designed to be used then. The API is also slightly misnamed and will be deprecated and have a more appropriate name and place in Vite 5.3 to make this more clear. Vite's own logic skips some of the steps during SSR but we did not which is why using this API with Remix resulted in pages not loading.