Fix @apply
selector rewriting when multiple classes are involved
#9107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems when using
@apply
:Given:
We would naively replace the .bar portion with
section
producing.foosection
which is obviously wrong. This did not happen when applyingfoo
because this simple replacement produced something that happened to be correctsection.bar
.Only replacing the first occurrence of a candidate in a selector:(reverted due to this not being 100% correct either)Given:
We would produce:
This is not correct because the
foo
class may not even exist at all if.foo + .foo
is defined in thecomponents
orutilities
layers.Fixes #9093