Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for portal targets #100

Closed
wants to merge 1 commit into from
Closed

Added functionality for portal targets #100

wants to merge 1 commit into from

Conversation

royteusink
Copy link

@royteusink royteusink commented Sep 29, 2016

support for portal targets. A way to place portals in targeted places in the document, rather than always at the bottom.

Fixes issue: #99

@jvitela
Copy link

jvitela commented Nov 24, 2016

Is this functionality planned to be merged? I would also find it very useful.

@Artsu
Copy link

Artsu commented Dec 14, 2016

Also interested about if/when this could be merged.

@robinfehr
Copy link

👍 would also be very interested.

@tajo
Copy link
Owner

tajo commented Dec 29, 2016

Ok, I want to merge this.

Can you (or somebody else) please update the README, add some tests and resolve conflicts?

Sorry for not responding sooner.
Thank you!

@tajo tajo added this to the v4 milestone Dec 29, 2016
@Hypnosphi
Copy link

  1. Can you make props.target accept a DOM element?
  2. Can you make it dynamic, i.e. support changing of target?

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Done: #157

@tajo tajo closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants