Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add className to containing div #155

Closed
wants to merge 1 commit into from
Closed

Add className to containing div #155

wants to merge 1 commit into from

Conversation

devinmcinnis
Copy link

Since this has been referenced from multiple issues, I want to add that even though react-portal does not allow setting a class name, it would be beneficial to have a class name for the component.

Currently, there is no way to target the containing <div> wrapper.

My use case is supporting a modal on iOS Safari. (CSS) Viewport units aren't functional/reliable with the expanding/collapsing menus and without being able to add height: 100% to the react-portal <div>, it's impossible to properly support.

#105 (comment)

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version (complete rewrite) of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

If you feel your PR still applies, please rebase it against the master and re-open it. Sorry for the lack of response in past! Thanks!

@tajo tajo closed this Oct 1, 2017
@devinmcinnis devinmcinnis deleted the patch-1 branch February 2, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants