Discussion: Rewrite #156
Closed
Discussion: Rewrite #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll look into. I'm going to use react-portal for one of our projects, so things should start moving again. |
Closed
|
Rewritten: #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten this module as react-portal-minimal, which contains many of the changes we discussed in #121, removes all internal state, halves the size of the module, supports
className(again), and removes most optional props, intending to make<Portal>a better building block for components that only need the subtree hoisting.More featureful components could be built on top of this new
<Portal>, but in my opinion options likecloseOnEscseem to cause more problems than they are worth to have in the core of this module.I don't intend for this PR to be merged as stated - it contains a
package.jsonrename & some tags - but I'd like to you have a look at it, and if you like the direction, I'll rebase it for a clean merge.