Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect gradle build dir for reports #270

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

takahirom
Copy link
Owner

@takahirom takahirom commented Feb 23, 2024

close #265

@takahirom takahirom force-pushed the takahirom/respect-gradle-build-dir/2024-02-23 branch from 03eae64 to 50236c4 Compare February 23, 2024 08:21
@takahirom takahirom merged commit 44498e3 into main Feb 23, 2024
5 checks passed
@takahirom takahirom deleted the takahirom/respect-gradle-build-dir/2024-02-23 branch February 23, 2024 08:51
github-merge-queue bot referenced this pull request in slackhq/circuit Mar 18, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi)
| plugin | minor | `1.10.1` -> `1.11.0` |
|
[io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi)
| dependencies | minor | `1.10.1` -> `1.11.0` |
|
[io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi)
| dependencies | minor | `1.10.1` -> `1.11.0` |
|
[io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi)
| dependencies | minor | `1.10.1` -> `1.11.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary>

###
[`v1.11.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.11.0)

[Compare
Source](https://togithub.com/takahirom/roborazzi/compare/1.10.1...1.11.0)

##### New feature

In Roborazzi, if you specify outputDir in the Gradle settings, you can
use [the build
cache](https://togithub.com/takahirom/roborazzi?tab=readme-ov-file#q-my-tests-are-being-skipped-or-conversely-are-being-run-when-they-should-be-skipped-how-can-i-handle-caching-to-address-this).
Now, Roborazzi passes the setting into the test.

build.gradle

    roborazzi {
        outputDir = "src/your/screenshot/folder"
    }


[gradle.propeties](https://togithub.com/takahirom/roborazzi?tab=readme-ov-file#roborazzirecordfilepathstrategy)


roborazzi.record.filePathStrategy=relativePathFromRoborazziContextOutputDirectory

Test

    captureRoboImage()
    -> saved src/your/screenshot/folder/package.class.method.png

    captureRoboImage("test.png")

    -> saved src/your/screenshot/folder/test.png

##### What's Changed

- Add helpful error message for class cast exception by
[@&#8203;takahirom](https://togithub.com/takahirom) in
[https://github.com/takahirom/roborazzi/pull/267](https://togithub.com/takahirom/roborazzi/pull/267)
- Use 'verify' task when specifying both 'compare' and 'verify' by
[@&#8203;takahirom](https://togithub.com/takahirom) in
[https://github.com/takahirom/roborazzi/pull/269](https://togithub.com/takahirom/roborazzi/pull/269)
- Respect gradle build dir for reports by
[@&#8203;takahirom](https://togithub.com/takahirom) in
[https://github.com/takahirom/roborazzi/pull/270](https://togithub.com/takahirom/roborazzi/pull/270)
- Add "The images taken from Roborazzi seem broken" FAQ by
[@&#8203;takahirom](https://togithub.com/takahirom) in
[https://github.com/takahirom/roborazzi/pull/277](https://togithub.com/takahirom/roborazzi/pull/277)

**Full Changelog**:
takahirom/roborazzi@1.10.1...1.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI1Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overriding of build dir
1 participant