[CI]Fix false positive diff in Roborazzi CI by using the same platform for store and compare #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
changed the title
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Apr 21, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.12.0` -> `1.13.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.12.0` -> `1.13.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.12.0` -> `1.13.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.12.0` -> `1.13.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.13.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.13.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.12.0...1.13.0) ##### Add experimental, minimal support for iOS in Compose Multiplatform Roborazzi has supported Compose Desktop, but we hadn't yet supported iOS, which could be a major use case for Compose Multiplatform. Therefore, I have added support for iOS. Now, you can record, compare, and verify just as you would with Android support. https://takahirom.github.io/roborazzi/compose-multiplatform.html#experimental-feature-ios-support  However, Roborazzi is fundamentally based on the JVM. Currently, we offer only minimal features. If you are interested in helping to improve these features, please take a look at these issues: [https://github.com/takahirom/roborazzi/issues/302](https://togithub.com/takahirom/roborazzi/issues/302) [https://github.com/takahirom/roborazzi/issues/305](https://togithub.com/takahirom/roborazzi/issues/305) ##### Changes Affecting Existing Support To support iOS, we have made some dependency changes for Android and Compose Desktop. I believe these changes will not affect existing behavior. However, if you notice anything, please let me know. All Kotlin: 1.8.22 -> 1.9.21 dropbox/differ: 0.0.1 -> 0.0.2 ##### Desktop Compose Version Compose Multiplatform: 1.4.3 -> 1.6.1 ##### What's Changed - Add Minimal Compose Multiplatform iOS Support by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/301](https://togithub.com/takahirom/roborazzi/pull/301) - \[docs]Fix docs page by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/303](https://togithub.com/takahirom/roborazzi/pull/303) - \[docs]Fix docs by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/304](https://togithub.com/takahirom/roborazzi/pull/304) - Add roborazzi-painter ios file for building klib by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/306](https://togithub.com/takahirom/roborazzi/pull/306) - \[CI]Fix false positive diff in Roborazzi CI by using the same platform for store and compare by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/307](https://togithub.com/takahirom/roborazzi/pull/307) - Remove unneeded jvm form compose ios by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/308](https://togithub.com/takahirom/roborazzi/pull/308) - Fix task and fix ios recording by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/310](https://togithub.com/takahirom/roborazzi/pull/310) - Fix iOS recording path by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/311](https://togithub.com/takahirom/roborazzi/pull/311) - Fix iOS golden path and report time logic by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/312](https://togithub.com/takahirom/roborazzi/pull/312) - Fix iOS comparison logic by [@​takahirom](https://togithub.com/takahirom) in [https://github.com/takahirom/roborazzi/pull/313](https://togithub.com/takahirom/roborazzi/pull/313) **Full Changelog**: takahirom/roborazzi@1.12.0...1.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.