Update plugin build and dependencies #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on takari/takari-pom#9 High level changes: - updated wrapper to latest - uses parent v 50 - remove/adjust prerequisites (needed only for plugin, parent POM not, etc) - get rid of animal sniffer as compiler use `release` flag - update plugin dependencies - update sources where depedendency introduced change - one IT changed: CompileAnnotationProcessingTest as it used source 1.6, that is unsupported by Java 17. Changed to `release 7` - update github workflow with distribution - styfle/cancel-workflow-action: bump With these changes the build works okay on Java 17 as well.
This was referenced Nov 5, 2022
|
@jvanzyl SNAPSHOT needs to be released io.takari:takari:pom:50-SNAPSHOT |
|
@ajayk asked for permission to deploy, once got, will do releases... Am currently fixing plugin IT framework that fail with mvn 3.8.6... |
|
Parent 50 released, needs some time to sync to Maven Central, then we can continue.... @ajayk |
|
IT framework failure reson w/ mvn 3.8.4+ is this commit: The change in DefaultMojoExecutionConfigurator.java causes NPE, as |
|
POM landed in Central, updated parent in this PR. |
|
Also, I'd make this 2.1.0 instead 2.0.10... wdyt? @ajayk |
ajayk
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on takari/takari-pom#9
High level changes:
releaseflagrelease 7With these changes the build works okay on Java 17 as well.