Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix launch on windows #34

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Fix launch on windows #34

merged 5 commits into from
Nov 26, 2019

Commits on Nov 12, 2019

  1. Fix launch on windows 

    Due to event loop implementation differences (see #31), we need to "pin"
the SelectorEventLoop for Windows platforms and use synchronous popen/wait
constructs.  Although non-windows platforms will use async constructs,
that decision is maintained in a variable so we can easily change behavior.

Fixes #31
    @kevin-bates
    kevin-bates committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    60a1462 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Base approach to handle selector policy on NB PR 5047

    @kevin-bates
    kevin-bates committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    8117d0c View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Adjust some popen params on windows

    @kevin-bates
    kevin-bates committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    d4c03c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Apply changes per review, fix py38-win issues.

    @kevin-bates
    kevin-bates committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    23a2ab6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Simply is_alive for Windows, use ipython master for 3.8 fix

    @kevin-bates
    kevin-bates committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    174f10e View commit details
    Browse the repository at this point in the history