Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluate API #11

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Fix evaluate API #11

merged 1 commit into from
Nov 22, 2019

Conversation

DhairyaLGandhi
Copy link

Addresses #10

@takuti takuti merged commit ca3bac9 into takuti:master Nov 22, 2019
@ghost
Copy link

ghost commented Jul 17, 2020

This change breaks calling cross_validation function because of

accum += evaluate(recommender, truth_data, metric(), k)

I get

ERROR: LoadError: MethodError: no method matching evaluate(::MF, ::DataAccessor, ::MAE, ::Int64)

for

cross_validation(3, MAE, 15, MF, data, 5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants