Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_lastfm data loader to get the user-artist listening frequency data #43

Merged
merged 4 commits into from
Feb 13, 2022

Conversation

takuti
Copy link
Owner

@takuti takuti commented Feb 13, 2022

Relates to #29

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #43 (2096051) into master (42fcd36) will decrease coverage by 21.03%.
The diff coverage is 3.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #43       +/-   ##
===========================================
- Coverage   98.28%   77.24%   -21.04%     
===========================================
  Files          22       22               
  Lines         641      668       +27     
===========================================
- Hits          630      516      -114     
- Misses         11      152      +141     
Impacted Files Coverage Δ
src/datasets.jl 11.32% <3.33%> (-88.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42fcd36...2096051. Read the comment docs.

@takuti
Copy link
Owner Author

takuti commented Feb 13, 2022

Coverage failure is expected as we skip the test cases involving a download operation: 2096051

@takuti takuti merged commit 75dfc22 into master Feb 13, 2022
@takuti takuti deleted the lastfm branch February 13, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants