Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify predict and ranking for simplicity #51

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

takuti
Copy link
Owner

@takuti takuti commented Feb 28, 2022

since ranking is used as a simple wrapper of predict.

since `ranking` is used as a simple wrapper of `predict`.
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #51 (16cfe67) into master (37cc748) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   78.63%   78.40%   -0.24%     
==========================================
  Files          23       23              
  Lines         716      713       -3     
==========================================
- Hits          563      559       -4     
- Misses        153      154       +1     
Impacted Files Coverage Δ
src/base_recommender.jl 96.00% <100.00%> (-4.00%) ⬇️
src/baseline/co_occurrence.jl 100.00% <100.00%> (ø)
src/baseline/most_popular.jl 100.00% <100.00%> (ø)
src/baseline/threshold_percentage.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cc748...16cfe67. Read the comment docs.

@takuti takuti merged commit da04857 into master Mar 1, 2022
@takuti takuti deleted the unify-predict-ranking branch March 1, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants