Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a log issue #368

Open
wants to merge 3 commits into
base: course
Choose a base branch
from
Open

fix a log issue #368

wants to merge 3 commits into from

Conversation

oocococo
Copy link
Contributor

@oocococo oocococo commented Jan 5, 2022

use consist format of "key" in logging

fix #367

Connor1996
Connor1996 reviewed Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if the key is not printable, outputting the string would cause confusion. Maybe using hex.EncodeToString for all the places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsist format of "key" in log
2 participants
@oocococo @Connor1996