Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage engine experiment of LSM-tree. #443

Open
wants to merge 22 commits into
base: course
Choose a base branch
from

Conversation

QingyangZ
Copy link

TinyDB is a course designed to help students quickly familiarize themselves with LSM-tree. Submitted by ADSL of USTC.

Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a course, please clean the implementation and give a tutorial

@QingyangZ
Copy link
Author

The implementation has been cleaned up and a tutorial has been added to doc/tinydb.

@QingyangZ
Copy link
Author

go-ycsb has been removed and added as a submodule

@@ -0,0 +1,3 @@
[submodule "go-ycsb"]
path = go-ycsb
url = [email protected]:QingyangZ/go-ycsb.git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can file another PR to https://github.com/pingcap/go-ycsb?

Comment on lines +42 to +44
replace github.com/jmhodges/levigo => ./levigo

replace github.com/tecbot/gorocksdb => ./gorocksdb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes? Just like the go-ycsb part, we need the diff to review them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've received feedback that the amount of code including go-ycsb is too large, so I've used a submodule instead.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I was commenting at levigo and gorocksdb, not go-ycsb. They should be submitted the same way as go-ycsb.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood your meaning earilier. The original gorocksdb has been slightly modified to fit the version of Rocksdb and levigo is not modified.

@@ -0,0 +1,69 @@
# Welcome to the TinyDB!
TinyDB is a course designed to help you quickly familiarize yourself with the underlying storage engine of [TiKV Project](https://github.com/tikv/tikv).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about regarding TinyDB as one lab of TinyKV? and I think TinyEngine would be less ambiguous.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion. I agree TinyEngine is more appropriate. I will modify the description in the next submission.

@boringhello
Copy link

Good work! Hope to see it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants