Port #4041 to hyperv-iso builder #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove steps that are windows specific
Move builder into correctly named folder
Use the convention for default hdd size Tests added for builder
…s how other system like VeeWee do it. Add support for number of cpus to use for vm Add support for vm generation
Attempt to stop vm, before deleting it
Setup local http server Add compaction of hard drive GetHostAdapterIpAddress function added for hyperv renamed step step_start_vm to step_run to fall in ine with naming conventions of other builders
…reate a dvd drive for os if it does not exist. Allow secure boot mode to be configured from config.
…e WinRM ports as well as SSH ports.
Get VName out of state. This allows template replacement to be run on vmname
…hines to have at least 1 iso image attached
Don't want to be prompted for confirmation from powershell commandlets
Default minimum and maximum sizes were geared towards spinning up windows server instances. Linux instances are far more efficient and make do with lower requirements. Set the minimum sizes to match this.
…n array. Otherwise powershell may treat it as a property. Stop-Vm with force parameter to ensure that powershell prompts will not appear
Fix code type for formatting Remove empty space
…icator configuration
Remove configuration elements that are no longer used.
…Server 2016 no longer come with iso. So default to not loading guest additions when the iso is missing
…uy Microsoft have changed the licensing to MPL2 and removed the copyright headers so that we can include it in the official Packer release. microsoft/packer-hyperv@1ce6ba9?diff=unified#diff-5d60887f0940c9f8d6724e59843ac1fb
|
I guess for now there is not a stable way to get the correct exit code from multiple operating systems. This was the reason I hacked in the exit code == 1 && len(errout) < 1. I am gonna give one final go tonight before I push merge button tommorow. |
|
@PatrickLang fix the conflict and I will merge it in |
|
Ack, I'll do a rebase. be right back Actually, it looks like the right change is on top. Is a squash or rebase actually needed? |
|
Submitted alternate #11 that has no conflicts, clean history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes taliesins/packer-baseboxes#2 :)