Fix Page Recursion into Categories #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quodrum-glas Thanks for this PR. I did test it with my mopidy-tidal plugin and did not notice any (breaking) changes. But I do believe I added some workarounds a while back to fix a similar issue so perhaps that is why? Have you got any example pages where this issue occurs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page iteration for child items expects PageCategory to have items but ALBUM_HEADER and ARTIST_HEADER is itself an item not an Object with items.
Wrapping those items in a pretend PageCategory so iteration will not throw an error.
Album has items itself but is a method and the error is even more confusing saying that items function can not be iterated.
Tests: local server test