AND-4928 move online attestation on backup flow #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozarezvlad
requested review from
iiiburnyiii,
Mama1emon,
Yoggam1 and
Sateetas
as code owners
Yoggam1
previously approved these changes
Jan 17, 2024
iiiburnyiii
reviewed
Jan 17, 2024
| @@ -65,7 +71,16 @@ class BackupService( | |||
| */ | |||
| var skipCompatibilityChecks: Boolean = false | |||
|
|
|||
| private val backupScope = CoroutineScope(Dispatchers.IO) + CoroutineExceptionHandler { _, throwable -> | |||
There was a problem hiding this comment.
Он не должен закрываться нигде? Или я не увидел просто?
There was a problem hiding this comment.
по логике не должно быть такого, что джобы висят и объект сервиса уже не нужен, + он не привязан к жц никак
Mama1emon
reviewed
Jan 17, 2024
Comment on lines
16
to
18
| private val onlineCardVerifier: OnlineCardVerifier = OnlineCardVerifier() | ||
| suspend fun getCertificate( |
There was a problem hiding this comment.
Странно, что детект схавал такой стиль. Мб строчку добавить между ними?
На твое усмотрение
| @@ -415,19 +474,20 @@ class PrimaryCard( | |||
| val batchId: String?, // for compatibility with interrupted backups | |||
| val firmwareVersion: FirmwareVersion?, // for compatibility with interrupted backups | |||
| val isKeysImportAllowed: Boolean?, // for compatibility with interrupted backups | |||
| ) : CertificateProvider { | |||
| constructor(rawPrimaryCard: RawPrimaryCard, issuerSignature: ByteArray) : this( | |||
| val certificate: ByteArray?, | |||
There was a problem hiding this comment.
А дата класс не требует переопределения equals из-за использования массива байт?
There was a problem hiding this comment.
требует, но тут смысла не имеет особого
kozarezvlad
force-pushed
the
feature/AND-4928-online-attestation-on-backup
branch
from
3c40ac4
to
2e7f8f4
Compare
kozarezvlad
force-pushed
the
feature/AND-4928-online-attestation-on-backup
branch
from
2e7f8f4
to
3fd66be
Compare
Mama1emon
approved these changes
Jan 17, 2024
iiiburnyiii
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.