-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AND-4928 move online attestation on backup flow #339
AND-4928 move online attestation on backup flow #339
Conversation
@@ -65,7 +71,16 @@ class BackupService( | |||
*/ | |||
var skipCompatibilityChecks: Boolean = false | |||
|
|||
private val backupScope = CoroutineScope(Dispatchers.IO) + CoroutineExceptionHandler { _, throwable -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Он не должен закрываться нигде? Или я не увидел просто?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по логике не должно быть такого, что джобы висят и объект сервиса уже не нужен, + он не привязан к жц никак
private val onlineCardVerifier: OnlineCardVerifier = OnlineCardVerifier() | ||
suspend fun getCertificate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Странно, что детект схавал такой стиль. Мб строчку добавить между ними?
На твое усмотрение
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
добавил
@@ -415,19 +474,20 @@ class PrimaryCard( | |||
val batchId: String?, // for compatibility with interrupted backups | |||
val firmwareVersion: FirmwareVersion?, // for compatibility with interrupted backups | |||
val isKeysImportAllowed: Boolean?, // for compatibility with interrupted backups | |||
) : CertificateProvider { | |||
constructor(rawPrimaryCard: RawPrimaryCard, issuerSignature: ByteArray) : this( | |||
val certificate: ByteArray?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А дата класс не требует переопределения equals из-за использования массива байт?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
требует, но тут смысла не имеет особого
3c40ac4
to
2e7f8f4
Compare
2e7f8f4
to
3fd66be
Compare
No description provided.