Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ios 4169 add bls signature lib #317

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Ios 4169 add bls signature lib #317

merged 5 commits into from
Aug 11, 2023

Conversation

skibinalexander
Copy link
Contributor

@skibinalexander skibinalexander commented Aug 10, 2023 •
edited by megakoko
Loading

  • Пока не лить, проверю на другом работу всех методов

@tureck1y tureck1y requested a review from megakoko August 10, 2023 13:41
tureck1y
tureck1y requested changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@tureck1y tureck1y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В подспек недостаточно добавить, потому что example работает с сдк напрямую, его тоже надо подправить

TangemSdk/TangemSdk/Fraemworks/Bls_Signature.xcframework/Info.plist Outdated Show resolved Hide resolved
megakoko
megakoko reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@megakoko megakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Использование фреймворка в другом МРе будет?

TangemSdk.podspec Outdated
Comment on lines 53 to 55
s.vendored_frameworks = 'TangemSdk/TangemSdk/Fraemworks/Bls_Signature.xcframework'

end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s.vendored_frameworks = 'TangemSdk/TangemSdk/Fraemworks/Bls_Signature.xcframework'
end
s.vendored_frameworks = 'TangemSdk/TangemSdk/Fraemworks/Bls_Signature.xcframework'
end

@skibinalexander
Copy link
Contributor Author

В подспек недостаточно добавить, потому что example работает с сдк напрямую, его тоже надо подправить

Тут честно сказать не очень понял, локально xcfraemwork тоже видно

Снимок экрана 2023-08-10 в 16 59 29

@skibinalexander
Copy link
Contributor Author

Использование фреймворка в другом МРе будет?

Использование в BlockchainSdk -> tangem/blockchain-sdk-swift#381

@skibinalexander skibinalexander mentioned this pull request Aug 10, 2023
Merged
@skibinalexander skibinalexander merged commit 49ebe54 into develop Aug 11, 2023
1 check passed
@skibinalexander skibinalexander deleted the IOS-4169-add-bls-signature-lib branch August 11, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tureck1y tureck1y tureck1y approved these changes

@megakoko megakoko megakoko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skibinalexander @tureck1y @megakoko