Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check add position before create doDDLJob() #13

Merged
merged 2 commits into from
Mar 9, 2022
Merged

ddl: check add position before create doDDLJob() #13

merged 2 commits into from
Mar 9, 2022

Conversation

Defined2014
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #12

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

check add position before create doDDLJob()

@tangenta tangenta merged commit ac202ff into multi-schema-change Mar 9, 2022
tangenta pushed a commit that referenced this pull request Jul 4, 2023
@wjhuang2016
Merge pull request #13 from tangenta/new_writer-3
361c752 
split subtasks according to stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
sig/sql-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check ast.ColumnPositionAfter relate columns before runDDL job.
2 participants
@Defined2014 @tangenta