ddl: support multi-schema change for drop columns #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined2014
reviewed
Mar 9, 2022
Defined2014
reviewed
Mar 9, 2022
| @@ -3904,14 +3904,14 @@ func checkIsDroppableColumn(ctx sessionctx.Context, t table.Table, spec *ast.Alt | |||
| return true, nil | |||
| } | |||
|
|
|||
| func checkDropVisibleColumnCnt(t table.Table, columnCnt int) error { | |||
| func checkVisibleColumnCnt(t table.Table, addCnt, dropCnt int) error { | |||
There was a problem hiding this comment.
How about combine checkDropVisibleColumnCnt and checkAddColumnTooManyColumns
There was a problem hiding this comment.
I prefer to separate them because they make different check.
Defined2014
approved these changes
Mar 10, 2022
tangenta
added a commit
that referenced
this pull request
Aug 19, 2022
tangenta
pushed a commit
that referenced
this pull request
Jul 11, 2023
collect and record the min max key in subtask meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note