Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Reductions #8

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

Chiloven945
Copy link

Did some enhancements and reductions to the strings to fit the space, fixed some grammar errors.
This pull request is undone, suggestion is welcome.

对原有的翻译做了一些优化与更改使其适应正常表达与适应屏幕空间,修复了一些语法错误。
这个pr还未完成,欢迎提出建议。

@Chiloven945
Copy link
Author

嗯……好像有些字符串缺,我到时候补回来……

@Chiloven945
Copy link
Author

提一嘴,估计是之前留下的东西,Kitchen Sink(水槽包)被意外地翻译为了烹饪……
image

@tangge233
Copy link
Owner

提一嘴,估计是之前留下的东西,Kitchen Sink(水槽包)被意外地翻译为了烹饪……

Hex-Dragon#4020 (review)
龙猫给的翻译对照是这么干的.jpg

@Chiloven945
Copy link
Author

( 拼写检查还是很重要的,现在也改不了了() Screenshot 2024-07-25 014504 Screenshot 2024-07-25 015445 Screenshot 2024-07-25 014438

@Chiloven945 Chiloven945 marked this pull request as ready for review July 24, 2024 18:03
@3gf8jv4dv
Copy link

3gf8jv4dv commented Jul 24, 2024

I will review this PR later.

拼写检查还是很重要的,现在也改不了了()

It does not matter, I or tangge233 will solve this kind of problem in the future.

@tangge233
Copy link
Owner

先合并了,翻译内容用action编译的PCL看了下没什么明显问题

@tangge233 tangge233 merged commit 7c2d0e6 into tangge233:Language Jul 25, 2024
5 checks passed
@tangge233
Copy link
Owner

这个换行真的有必要吗(
四个语言文件行数不一样,强迫症犯了(

最后的效果是一样的,但这样似乎更方便翻译人员(毕竟谁也忍受不了一行塞千行

@Chiloven945
Copy link
Author

这个换行真的有必要吗( 四个语言文件行数不一样,强迫症犯了(

crowdin导出来就会变成这样()

Copy link

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I knew this PR was an overhaul, but I did not expect it to be such an overhaul.

I noticed some minor issues, I will try to fix those.

<s:String x:Key="LangPageVersionSetupJVMTail">Text fields will be joined directly at the end of the launch parameter.
For example, typing &quot;--demo&quot; will launch the game in demo mode.
If left as blank, the value of the global setting is used.</s:String>
<s:String x:Key="LangPageVersionSetupCommand">This option does not override global settings: Executes the specific command or program before Minecraft is launched.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the original Simplified Chinese text, there is one paragraph missing that explains the precedence of instance settings vs. global settings. I think this is relatively important.

<s:String x:Key="LangDialogTitleAuthlibEnableLittleSkin">Third-party Login Confirmation</s:String>
<s:String x:Key="LangDialogAuthlibEnableLittleSkinServer">Do you want to login using LittleSkin in the instance {0}?&#x000D;Authlib server: {1}&#x000D;&#x000D;You can modify the login method in "Instance Properties → Settings → Server Options".</s:String>
<s:String x:Key="LangHintWindowDropExtract">Please extract the file before dragging it in!</s:String>
<s:String x:Key="LangDialogAuthlibEnableLittleSkinServer">Do you want to log in using LittleSkin in the instance {0}?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the original Simplified Chinese text for this says authlib server, not LittleSkin.

I looked through the commit history and it seems like it was messed up from the beginning?

Comment on lines +979 to +980
<s:String x:Key="LangPageSetupSystemDownloadAccessibilityRemindGameUpdateBeta">Beta Update</s:String>
<s:String x:Key="LangPageSetupSystemDownloadAccessibilityRemindGameUpdateBetaToolTip">Display a hint when a new Minecraft beta version (snapshot, pre-release) is released.</s:String>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, Beta in the Minecraft English community is mostly used to describe the stage before Release. I recommend using Development Update because it is clearer and consistent with the other text in this file.

<s:String x:Key="LangModCompModDownloadMillion">million downloads</s:String>
<s:String x:Key="LangModCompModDependentCount">dependencies, </s:String>
<s:String x:Key="LangModCompModDownload">downloads, </s:String>
<s:String x:Key="LangModCompModDownloadMillion">downloads in 10k, </s:String>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit strange, but it is limited by the structure of the code itself. Maybe it needs to be rewritten in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formats of the date and the number counting method have a huge different between English and Chinese.
There still are a bunch of works on pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants