-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tangle-dapp): Add liquid staking unstaking card #2415
Conversation
✅ Deploy Preview for tangle-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…s/webb-dapp into yuri/ls-unstaking-card
…app into yuri/ls-unstaking-card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 comment, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update copy for modal to remove mention of NFTs: "After the schedule period completes, you can withdraw unstaked tokens."
- Update button to view explorer instead.
- Unsure if it is due to the background image, but the transaction input components seem inconsistent to latest Figma designs, default, hover, and error states can be referenced here in design system
- Wallet balance
- Select validators button
- Select network dropdown button
- Have a blue/purple (Tangle's primary color) border to denote
tg
versions of the tokens' icons - Chevron icons & on-hover styling of them
(the above components should be reused in restaking as well, unsure if @AtelyPham has worked on these)
- Remove background fill to fees component
@yurixander I got overflow UI when using Arc browser on Liquid Staking page
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
apps/tangle-dapp/components/LiquidStaking/LiquidStakingInput.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍! The CI is still failing @yurixander.
@vutuanlinh2k2 I'm not seeing the UI overflow problem on my end, also the UI on your screenshot seems to be from previous code... do you happen to be on the most up to date version of this branch? |
@AtelyPham Seems like a tiny bug regarding table headers was introduced in #2436: |
Can you check again on the |
@AtelyPham Check here: https://deploy-preview-2436--tangle-dapp.netlify.app/nomination, for some reason the |
Summary of changes
Provide a detailed description of proposed changes.
redeem
extrinsic will fail.formatBn
no longer uses confusing regex).formatBn
function which was causing certain values like0.0001
to be incorrectly formatted as0.1
.Proposed area of change
Put an
x
in the boxes that apply.apps/bridge-dapp
apps/hubble-stats
apps/stats-dapp
apps/tangle-dapp
apps/testnet-leaderboard
apps/faucet
apps/zk-explorer
libs/webb-ui-components
Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g.
Closes #233
).tgDOT
back toDOT
) #2336Screen Recording
If possible provide a screen recording of proposed change.
liquid-staking-unstake.webm
Code Checklist
Please be sure to add .stories documentation if any additions are made to
libs/webb-ui-components
.