Add proposals packages and remove dependence on sdk-core #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewstone
changed the title
drewstone
force-pushed
the
drew/move-over-sdk-core-utils
branch
from
fceff12
to
0ab6bcf
Compare
|
These are the files that the dApp uses from |
|
Looks like this should cover all those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step in migrating what we use mostly from
sdk-coreintoprotocol-solidity. The purpose of this is to eventually deprecatewebb.js. That repo is a nuisance and a pain to maintain.@AtelyPham please let me know if there are utilities the dApp is using from
webb.jsthat are not migrated here. If they belong in this repo I will add them, otherwise we should discuss getting them into the dApp repo.