Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SetMaintainer trait and implement for signature bridge #304

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add SetMaintainer trait and implement for signature bridge #304

merged 1 commit into from
Mar 14, 2023

Conversation

drewstone
Copy link
Contributor

@drewstone drewstone commented Mar 13, 2023 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Adds SetMaintainer trait for directly setting maintainer from external systems (DKG for example).

salman01zp
salman01zp approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@salman01zp salman01zp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .!!

shekohex
shekohex approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! that would be useful if both DKG and Signature Bridge pallet are on the same runtime, that would do the update automatically, without the need for an external system (e.g Relayers) to do that.

@drewstone drewstone merged commit 77108fe into main Mar 14, 2023
@drewstone drewstone deleted the drew/set-maintainer-directly branch March 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@salman01zp salman01zp salman01zp approved these changes

@1xstj 1xstj Awaiting requested review from 1xstj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewstone @salman01zp @shekohex