Introduce running of protocol substrate node and dkg node via the test-utils package #278

dharjeezy · 2022-09-06T11:13:22Z

PR Description

This PR solves part of the issue in #270 so as to start up different node types such as

The Protocol substrate node
The DKG node

…ami/consolidate-test-util � Conflicts: � package.json

packages/test-utils/src/substrate/substrateNodeBase.ts

dutterbutter · 2022-09-06T13:41:20Z

packages/test-utils/src/substrate/localProtocolSubstrate.ts

+} from './substrateNodeBase.js';
+
+const STANDALONE_DOCKER_IMAGE_URL =
+  'ghcr.io/webb-tools/protocol-substrate-standalone-node:edge';


Can we use stable version here?

The stable version is not with consistent with master.

Thanks for checking @dharjeezy, @dutterbutter please make sure we keep things up to date. I'm not sure what stable is but possibly worth removing. Would rather we consider something called production instead of stable.

stable is a deployed docker image on protocol-substrate. It's purpose is to prevent all of our CIs from breaking when a breaking change is made on protocol-substrate. Changing the name is trivial - but would welcome suggestions on better methods for releasing software incrementally across our repos.

packages/test-utils/src/substrate/substrateNodeBase.ts

+    image: string;
+  }): void {
+    if (!this.checkIfImageExists(opts.image) || opts.frocePull) {
+      execSync(`docker pull ${opts.image}`, {


drewstone

LG so far, need more comments and would appreciate formatting more things.

tests/utils/backend-utils.ts

drewstone · 2022-09-07T13:09:40Z

packages/api/package.json

-  "main": "./cjs/index.js",
-  "module": "./index.js",
-  "types": "./index.d.ts",
+  "main": "./build/cjs/index.js",


CC @nepoche to check these since he would know best if this is how we should point to the files. Have a feeling we shouldn't have this. Any reason why its added @dharjeezy ?

Yh, so i was having issue trying to use the package in the integration tests. So, i had to point to the files like that just as it is being done here https://github.com/webb-tools/webb.js/blob/master/packages/sdk-core/package.json

This is consistent with the way we are building packages for the monorepo, esm, and cjs.

packages/test-utils/src/substrate/substrateNodeBase.ts

.eslintignore

nepoche · 2022-09-07T22:00:46Z

packages/api/package.json

-  "main": "./cjs/index.js",
-  "module": "./index.js",
-  "types": "./index.d.ts",
+  "main": "./build/cjs/index.js",


This is consistent with the way we are building packages for the monorepo, esm, and cjs.

packages/test-utils/src/substrate/substrateNodeBase.ts

nepoche · 2022-09-07T22:16:35Z

packages/test-utils/src/substrate/localProtocolSubstrate.ts

+} from './substrateNodeBase.js';
+
+const STANDALONE_DOCKER_IMAGE_URL =
+  'ghcr.io/webb-tools/protocol-substrate-standalone-node:edge';


stable is a deployed docker image on protocol-substrate. It's purpose is to prevent all of our CIs from breaking when a breaking change is made on protocol-substrate. Changing the name is trivial - but would welcome suggestions on better methods for releasing software incrementally across our repos.

tests/utils/backend-utils.ts

Co-authored-by: nepoche <[email protected]>

packages/test-utils/src/substrate/substrateNodeBase.ts

Co-authored-by: nepoche <[email protected]>

… dami/consolidate-test-util # Conflicts: # packages/test-utils/src/substrate/substrateNodeBase.ts

tests/utils/backend-utils.ts

…ami/consolidate-test-util

tests/integration_tests/substrate/mixerTests.spec.ts

dutterbutter · 2022-09-28T13:24:26Z

@dharjeezy please resolve conflicts

…ami/consolidate-test-util � Conflicts: � packages/test-utils/package.json

dharjeezy added 2 commits September 2, 2022 23:46

substrate package util

e3106bf

Merge branch 'master' of https://github.com/webb-tools/webb.js into d…

616b68b

…ami/consolidate-test-util � Conflicts: � package.json

github-advanced-security bot found potential problems Sep 6, 2022

View reviewed changes

packages/test-utils/src/substrate/substrateNodeBase.ts Fixed Show fixed Hide fixed

local dkg setup

129031d

dutterbutter reviewed Sep 6, 2022

View reviewed changes

stable

ef8d287

dharjeezy requested a review from dutterbutter September 6, 2022 13:45

dharjeezy added 3 commits September 6, 2022 17:17

make use of substrate nodes in the mixer

b1bf36e

make use of test util substrate node for the mixer

89bb8bb

lint

0e2f7c6

github-advanced-security bot found potential problems Sep 6, 2022

View reviewed changes

other tests use test-util

10f986c

dharjeezy changed the title ~~substrate package util~~ Introduce running of protocol substrate node and dkg node via the test-utils package Sep 6, 2022

dharjeezy added 3 commits September 6, 2022 22:34

fetch leaves

b2f2f78

unskip tests

110be28

startWebbNode()

0c7f007

dharjeezy marked this pull request as ready for review September 7, 2022 13:04

drewstone requested changes Sep 7, 2022

View reviewed changes

dutterbutter requested a review from nepoche September 7, 2022 13:12

dutterbutter added the needs review 👓 Pull request needs a review label Sep 7, 2022

dharjeezy added 2 commits September 7, 2022 17:04

introduce rpc properties

2fbc9b9

fix lint

d5dd729

dharjeezy requested a review from AhmedKorim September 7, 2022 21:40

Merge branch 'master' into dami/consolidate-test-util

a813013

nepoche suggested changes Sep 7, 2022

View reviewed changes

dharjeezy and others added 3 commits September 8, 2022 00:18

Update tests/utils/backend-utils.ts

b4d2f4c

Co-authored-by: nepoche <[email protected]>

Update tests/utils/backend-utils.ts

a4ee85d

Co-authored-by: nepoche <[email protected]>

start webb nodes

6f232ba

dutterbutter added needs changes 🔧 PR has requested changes or conflicts that need to be addressed and removed needs review 👓 Pull request needs a review labels Sep 8, 2022

Merge branch 'master' into dami/consolidate-test-util

01dc288

dharjeezy requested review from nepoche and drewstone September 8, 2022 18:11

dharjeezy added needs review 👓 Pull request needs a review and removed needs changes 🔧 PR has requested changes or conflicts that need to be addressed labels Sep 8, 2022

nepoche reviewed Sep 12, 2022

View reviewed changes

packages/test-utils/src/substrate/substrateNodeBase.ts Outdated Show resolved Hide resolved

dharjeezy and others added 5 commits September 12, 2022 16:06

Update packages/test-utils/src/substrate/substrateNodeBase.ts

27e111b

Co-authored-by: nepoche <[email protected]>

remove unwanted configs

1fff4ca

Merge remote-tracking branch 'origin/dami/consolidate-test-util' into…

60fade2

… dami/consolidate-test-util # Conflicts: # packages/test-utils/src/substrate/substrateNodeBase.ts

remove unwanted configs

5a5daa6

lint fix

d5be3d6

dutterbutter requested review from nepoche and removed request for dutterbutter September 14, 2022 08:25

nepoche suggested changes Sep 15, 2022

View reviewed changes

tests/utils/backend-utils.ts Outdated Show resolved Hide resolved

tests/utils/backend-utils.ts Outdated Show resolved Hide resolved

tests/utils/backend-utils.ts Outdated Show resolved Hide resolved

nepoche added needs changes 🔧 PR has requested changes or conflicts that need to be addressed and removed needs review 👓 Pull request needs a review labels Sep 15, 2022

dharjeezy added 3 commits September 16, 2022 12:39

changes

1c75253

Merge branch 'master' of https://github.com/webb-tools/webb.js into d…

a2de406

…ami/consolidate-test-util

unskip

f03d8af

dharjeezy requested review from nepoche and dutterbutter September 16, 2022 11:42

nepoche reviewed Sep 19, 2022

View reviewed changes

tests/integration_tests/substrate/mixerTests.spec.ts Outdated Show resolved Hide resolved

remove any type

357fe9f

dharjeezy requested a review from nepoche September 19, 2022 20:53

dutterbutter removed their request for review September 28, 2022 13:25

dharjeezy added 2 commits September 28, 2022 14:35

Merge branch 'master' of https://github.com/webb-tools/webb.js into d…

f17a6f7

…ami/consolidate-test-util � Conflicts: � packages/test-utils/package.json

merge changes

2f678cc

drewstone merged commit dfb0bc0 into master Sep 29, 2022

drewstone deleted the dami/consolidate-test-util branch September 29, 2022 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce running of protocol substrate node and dkg node via the test-utils package #278

Introduce running of protocol substrate node and dkg node via the test-utils package #278

dharjeezy commented Sep 6, 2022 •

edited

Loading

dutterbutter Sep 6, 2022

dharjeezy Sep 7, 2022 •

edited

Loading

drewstone Sep 7, 2022 •

edited

Loading

nepoche Sep 7, 2022

drewstone left a comment

drewstone Sep 7, 2022

dharjeezy Sep 7, 2022

nepoche Sep 7, 2022

nepoche Sep 7, 2022

nepoche Sep 7, 2022

dutterbutter commented Sep 28, 2022

Introduce running of protocol substrate node and dkg node via the test-utils package #278

Introduce running of protocol substrate node and dkg node via the test-utils package #278

Conversation

dharjeezy commented Sep 6, 2022 • edited Loading

PR Description

dutterbutter Sep 6, 2022

Choose a reason for hiding this comment

dharjeezy Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

drewstone Sep 7, 2022 • edited Loading

Choose a reason for hiding this comment

nepoche Sep 7, 2022

Choose a reason for hiding this comment

drewstone left a comment

Choose a reason for hiding this comment

drewstone Sep 7, 2022

Choose a reason for hiding this comment

dharjeezy Sep 7, 2022

Choose a reason for hiding this comment

nepoche Sep 7, 2022

Choose a reason for hiding this comment

nepoche Sep 7, 2022

Choose a reason for hiding this comment

nepoche Sep 7, 2022

Choose a reason for hiding this comment

dutterbutter commented Sep 28, 2022

dharjeezy commented Sep 6, 2022 •

edited

Loading

dharjeezy Sep 7, 2022 •

edited

Loading

drewstone Sep 7, 2022 •

edited

Loading