expression: implement vectorized evaluation for builtinRoundWithFracI…

…ntSig (pingcap#12103)
tangwz · Sep 23, 2019 · ff1aa5e · ff1aa5e
1 parent 50bd8e9
commit ff1aa5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/expression/builtin_math_vec.go b/expression/builtin_math_vec.go
@@ -474,6 +474,9 @@ func (b *builtinRoundIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column
 }
 
 func (b *builtinRoundIntSig) vectorized() bool {
+	return true
+}
+
 func (b *builtinRoundWithFracIntSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
 	if err := b.args[0].VecEvalInt(b.ctx, input, result); err != nil {
 		return err

diff --git a/expression/builtin_math_vec_test.go b/expression/builtin_math_vec_test.go
@@ -75,6 +75,7 @@ var vecBuiltinMathCases = map[string][]vecExprBenchCase{
 	ast.Round: {
 		{retEvalType: types.ETDecimal, childrenTypes: []types.EvalType{types.ETDecimal}},
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt}},
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: []dataGenerator{nil, &rangeInt64Gener{-100, 100}}},
 	},
 	ast.Pow: {
 		{retEvalType: types.ETReal, childrenTypes: []types.EvalType{types.ETReal, types.ETReal}, geners: []dataGenerator{&rangeRealGener{0, 10, 0.5}, &rangeRealGener{0, 100, 0.5}}},