Fix source map root #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew0
force-pushed
the
fix-source-map-root
branch
from
e14a0cf
to
5a0ea9b
Compare
isaacs
force-pushed
the
fix-source-map-root
branch
from
5a0ea9b
to
610c01c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Since tsimp provides a virtual folder to the TypeScript compiler, the output source maps will contain relative paths that might not necessarily align with the actual source files. This change sets the
sourceRootoption to the resolvedrootDirpath from the tsconfig, which lets Node find the original source files for debugging/stack traces.After this change, the inlined source maps contain the current working directory in the source map
sourceRootfield, so I updated the snapshots tests to filter out the source map like 4f314b0