-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Need help with v3
alpha|beta testing
#288
Comments
And yes - the first tag is |
I'll absolutely be checking it out and will provide my feedback.
I've integrated this project into the templates of all my own apps, I very
much appreciate the work put in.
…On Sat, Jun 29, 2024, 2:36 PM Pаramtamtām ***@***.***> wrote:
And yes - the first tag is ghcr.io/tarampampam/error-pages:3.0.0-alpha-1
😆
—
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD63FOLFK5KZYTPZLYVEMLZJ35EBAVCNFSM6AAAAABKDMXMNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGI4TCNJQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Used the alpha version on my internal ingress for a couple of days. No issues at all. Configured an ingress to test error codes:
and so on, and it picked up all codes beautifully. Text-only results for curl much appreciated! Planning to test the drop-in templates with Like the previous poster I love these error pages, I haven't looked back since I found them. |
Note RPS 11k → 18k |
@tarampampam You mentioned in #257 that this v3 update would work to resolve the issue described. Is this something that is currently achievable or still in the works? I see the ability to override the json response, but I need to do so per request rather than at the serve level. Ive not yet tried the update, hoping to get some time this week to start working on things again. |
I've released the first beta version: I'll wait a few days for testing. If you confirm that everything is okay and no issues are found, I'll go ahead and release a stable version. Does that sound good? |
@tarampampam Does this include the support of my issue at #285 ? |
Since there is no longer a config file - simply mount the HTML file with your template, set the Note I have updated the readme file: Lines 111 to 153 in b4e9ea5
|
Hey @tarampampam 👋 I have some questions looking through the (new) README. I have compose configs which still contain If that's clear to me, I can adjust my configs and start trying out the new v3 beta image too 👌 p.s. Thank you for your continued hard work 🥇 |
@ToshY I'm currently collecting all the changes in the first comment in #287, which will become the release description. This is why I haven't yet written an upgrade guide in the README file. Yes, those environment variables have been removed and are no longer needed. If you could share your experience upgrading from v2 to v3, I would greatly appreciate it, as it may help others have a smoother upgrade process! p.s. TY for your help with testing! |
Hello everyone!
I've been working hard over the past few weeks on a major version of this project, and my work is nearly complete. The most important parts are done and ready to be tested. Please note that the following changes are not backward-compatible, which is why this is a major update:
error-pages.yml
) is no longer needed. Everything is now configured using CLI flags and environment variables--add-template /path/to/your/tpl.htm
v2
, some have changed. Please update your charts accordingly. For the latest information, check here. The README file is still in progress, but the CLI documentation is available/{code}
,/{code}.html
, and/{code}.htm
. Additionally, you can use the flag--send-same-http-code
to retain the same HTTP status code as the page, if needed--add-http-code="…"
in the format%code%=%message%/%description%
. Moreover, you can use "placeholder" codes like4**
, which means if the requested code is not described but is between 400 and 499, the provided message with its description will be returned. This approach is similar to the one used in the OpenAPI specification, where instead of describing each code individually, you can describe a patterncurl
an error page, you will receive more readable content without tons of HTML tags. This change should not cause any issues, but it mayI am still deciding on two things - whether to keep thefasthttp
HTTP server or switch to thestdlib
HTTP server, and whether to keep the templates caching mechanism used inv2
. Currently, I have switched to thestdlib
HTTP server (due to better support and built-in HTTP/2 support, though with lower performance - 40k RPS has dropped to 11k). I've also removed the caching mechanism, which should reduce memory consumption but may increase CPU load slightly. I haven't finalized these decisions yet, so please share your thoughtsl7-dark
andl7-light
have been merged into a singlel7
theme, and thematrix
theme has been removed (because I created it and it wasn't very appealing)/metrics
has been not implemented yet, If someone found it useful and has used it - just tell me, and I'll re-implement itI'm reaching out to see if anyone would like to assist with early testing of the app. I can provide early builds (Docker image tags) via messages in this thread. It would be fantastic if you could run them locally or on your staging cluster and provide feedback on whether everything is working smoothly or if you encounter any issues.
Please leave a comment to let me know if you're willing to help. Your assistance would be greatly appreciated!
/cc @deffcolony @moschlar @r2DoesInc @fuog @kfirfer @CodeAnthem @NicosKaralis @GoliathLabs @onedr0p @modem7 @ToshY
The text was updated successfully, but these errors were encountered: