replicaset_mode: allow api call in init state #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the other hand, you can close this pr and issue. Since this is not a bug, but a special case when the user, without checking the current state of the queue with the public |
LeonidVas
reviewed
Sep 7, 2023
LeonidVas
approved these changes
Sep 7, 2023
0x501D
force-pushed
the
0x501D/fix-gh-216
branch
3 times, most recently
from
b7b4832
to
78cffa6
Compare
In replicaset mode, the user can attempt to call public methods on the replica start. For example, a single script is used for master and replica. This patch allows you to call a public method in the INIT state without interrupting the script by exiting with an obscure error. It will only log an attempt to call a method from the check_state function, which is present at the beginning of each public method. Closes #216
0x501D
force-pushed
the
0x501D/fix-gh-216
branch
from
78cffa6
to
348f4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replicaset mode, the user can attempt to call public methods on the replica start.
For example, a single script is used for master and replica.
This patch allows you to call a public method in the INIT state without
interrupting the script by exiting with an obscure error.
It will only log an attempt to call a method from the check_state function,
which is present at the beginning of each public method.
Closes #216