Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respond to bots #164

Merged
merged 1 commit into from
Mar 23, 2021
Merged

feat: respond to bots #164

merged 1 commit into from
Mar 23, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Mar 23, 2021

❤ THANKS FOR HELPING OUT :D

Proposed change

adds global respond_to_bot setting to allow your bot to consider messages originating from other bots for matching. it generally frowned upon to respond to other bots, so false is the default. more granular control at a rule level may be introduced later. it looks like this was default behavior for the current Telegram integration.

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 680906091

  • 0 of 60 (0.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 36.199%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/discord/remote.go 0 2 0.0%
remote/slack/helper.go 0 23 0.0%
remote/telegram/remote.go 0 35 0.0%
Files with Coverage Reduction New Missed Lines %
remote/slack/helper.go 2 0%
Totals Coverage Status
Change from base Build 666755234: -0.3%
Covered Lines: 838
Relevant Lines: 2315

💛 - Coveralls

@wass3r wass3r merged commit 6002966 into master Mar 23, 2021
@wass3r wass3r deleted the feat/respondtobots branch March 23, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants