Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(matcher): don't panic on unsupported regex #211

Merged
merged 1 commit into from
Nov 28, 2021
Merged

fix(matcher): don't panic on unsupported regex #211

merged 1 commit into from
Nov 28, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 28, 2021 •
edited
Loading

closes #80

instead of panic-ing, we log an error and return a no-match,

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1512019683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 1509400108: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@wass3r wass3r merged commit c3be550 into main Nov 28, 2021
@wass3r wass3r deleted the fix/unsupported-regex branch November 28, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanSussman JordanSussman Awaiting requested review from JordanSussman JordanSussman is a code owner

@pa3ng pa3ng Awaiting requested review from pa3ng

@sjqnn sjqnn Awaiting requested review from sjqnn sjqnn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't panic on unsupported regex error
2 participants
@wass3r @coveralls