Channel info #70
Channel info #70
Conversation
Pull Request Test Coverage Report for Build 136
💛 - Coveralls |
| @@ -396,6 +396,10 @@ func populateMessage(message models.Message, msgType models.MessageType, channel | |||
| message.ChannelName = name | |||
| } | |||
|
|
|||
| // make channel variables available | |||
| message.Vars["_channel.id"] = message.ChannelID | |||
| message.Vars["_channel.name"] = message.ChannelName // will be empty if it came via DM | |||
There was a problem hiding this comment.
DM's have a channel ID in Slack, too. Are you sure this wont get populated? It would actually be useful to me if it did.
There was a problem hiding this comment.
just _channel.name will be empty, _channel.id will be there
There was a problem hiding this comment.
Ok, I guess that makes sense. Although on the eDiscovery API they have names, too. (based on the participants)
There was a problem hiding this comment.
Ah, not familiar with that. There's a story for looking at Conversations API (#46) that might help. Though in a 1:1 conversation, name still seems to be omitted, it seems, according to: https://api.slack.com/methods/conversations.info
There was a problem hiding this comment.
Yeah, I think its fine to have an empty name for DMs. Just an interesting idea.
Co-Authored-By: wass3r <[email protected]>
|
@JordanSussman one more time? i think we resolved everything. |
❤ THANKS FOR HELPING OUT :D
Proposed change
This makes
{_channel.name}and{_channel.id}available as variables in your rules.Types of changes
What types of changes is this pull request introducing to flottbot? Put an
xin the boxes that applyChecklist
You can fill this out after creating your PR. Put an
xin the boxes that apply