This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Guaranteed order in deduplication dictionary hashes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 29, 2018 16:12
Signed-off-by: Cameron Hall <[email protected]>
Signed-off-by: Cameron Hall <[email protected]>
Signed-off-by: Cameron Hall <[email protected]>
Signed-off-by: Cameron Hall <[email protected]>
CameronJHall
changed the title
abstract-base-method
suggested changes
Dec 7, 2018
abstract-base-method
added
enhancement
awating contributor
Co-Authored-By: cjhall1283 <[email protected]>
|
It's also worth noting that this only effects T1 deduplication so there is almost no cost to migrate from 2.4.x to 2.5.0. |
abstract-base-method
previously approved these changes
Dec 12, 2018
Signed-off-by: Cameron Hall <[email protected]>
Signed-off-by: Cameron Hall <[email protected]>
|
using |
abstract-base-method
approved these changes
Dec 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GREASE Developer Pull Request Checklist Guaranteed order in deduplication dictionary hashes
USE THIS TEMPLATE FOR YOUR PULL REQUEST!
Purpose
In deduplication, the order of items in the dictionary to be hashed is not guaranteed. This PR fixes that by turning an unsorted dictionary into an ordered tuple before hashing.
Expected Outcome
Hashes will be consistent regardless of the ordering of the incoming dictionary in deduplication.
Checklist