Skip to content

Commit

Permalink
deps: silence irrelevant V8 warning
Browse files Browse the repository at this point in the history
PR-URL: nodejs#37587
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
  • Loading branch information
targos committed Mar 17, 2022
1 parent 642089c commit 47e80dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.5',
'v8_embedder_string': '-node.6',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-script.h
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ class V8_EXPORT Module : public Data {
*/
int GetIdentityHash() const;

using ResolveCallback V8_DEPRECATED("Use ResolveModuleCallback") =
using ResolveCallback =
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
Local<Module> referrer);
using ResolveModuleCallback = MaybeLocal<Module> (*)(
Expand Down

0 comments on commit 47e80dc

Please sign in to comment.