Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

XKCD 961 Eternal Flame animated gif #37

Closed
antonc42 opened this issue May 26, 2017 · 10 comments
Closed

XKCD 961 Eternal Flame animated gif #37

antonc42 opened this issue May 26, 2017 · 10 comments
Labels

Comments

@antonc42
Copy link
Contributor

https://xkcd.com/961/

The image is an animated gif, but is renamed with .jpg extension when downloaded.

@tasdikrahman
Copy link
Owner

tasdikrahman commented May 26, 2017 via email

@antonc42
Copy link
Contributor Author

After looking, it does seem to be a simple fix. I submitted a PR #38. I tested it by downloading all the comics again and it found a few more gifs than just 961. There was also 1116, 1264, and 1331.

@tasdikrahman
Copy link
Owner

Good work @antonc42 👍

Thanks for the contribution. Will update the pip module in a while

@antonc42
Copy link
Contributor Author

No problem! Thank you for the awesome app!

@tasdikrahman
Copy link
Owner

tasdikrahman commented May 28, 2017 via email

@antonc42
Copy link
Contributor Author

I just discovered it recently. I'm using it to create a screensaver slideshow of the comics.

@tasdikrahman
Copy link
Owner

tasdikrahman commented May 28, 2017

Ah. That's nice. Would be great if you can share how did you find xkcd-dl, was curious about it?

And please keep me posted on this project of yours. Would love to have a look at it.

Cheers!

@antonc42
Copy link
Contributor Author

There's not really much to it. I use your app to download all the comics to a directory and then point my screensaver at it. The only other thing I did was to put the alt text at the bottom of the image. I just do that with a little bash script. https://gist.github.com/antonc42/01742c560eb741b4ca543c966fe22cc0

@tasdikrahman
Copy link
Owner

Looks good man. @antonc42

Would love to put your project on the README.md under a title like projects using xkcd-dl if you don't mind

@antonc42
Copy link
Contributor Author

Sure, fine by me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants