Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I've done as a follow-up on #4
So, I've upgraded iced's wgpu in a fork:
https://github.com/kulkalkul/iced/commits/self-usage
I've done it, so it is non-breaking. Those expect calls there are similar in how it handles pre-wgpu 0.14. It is also handled the same in
https://github.com/sconybeare/wgpu_glyph/tree/wgpu-0.15
For bevy_iced, there are two changes I think you might be interested in:
Aside from the above points, a bug causes flashing rendering for UI. It happens randomly, at a random rate, sometimes so slow it is unnoticeable. Here is the video of it:
FAST FLICKERING VIDEO, EPILEPSY/SEIZURE WARNING!
magellan_2023-03-23_11-28-49.mp4
I've figured that the new pipelined rendering implementation causes
IcedNode::run
to run parallel toIcedContext::display
. As a result, the run function misses theIcedProp.did_draw
change. I didn't know the project enough to solve it, so I decided to ask it.I hope this isn't too long 😅