Feat transform commands #958
Conversation
commands/addJob-9.lua
Outdated
| @@ -56,7 +56,7 @@ local parentQueueKey | |||
| local parentData | |||
|
|
|||
| -- Includes | |||
| --- @include "includes/destructureJobKey" | |||
| --- @include "destructureJobKey" | |||
There was a problem hiding this comment.
I think it is good to keep the underlying structure, it is a pity to only support a global flat directory structure.
There was a problem hiding this comment.
From my experience, a flat structure can get unruly. My includes folder currently has 50 files, and I'd imagine that over time "includes" could greatly outnumber main scripts in bullmq.
There was a problem hiding this comment.
Another thought: I was planning on refactoring some of the scripts to be more reusable - for example removeJob-1.lua (to implement removeJobsByPattern). I think it would be confusing to have a main script and its utility file named similarly in the same folder.
There was a problem hiding this comment.
Sounds good to me, I'll try to transform our scripts keeping the folder structure in some way
| "ioredis": "^4.28.2", | ||
| "lodash": "^4.17.21", | ||
| "minimatch": "^3.0.4", |
There was a problem hiding this comment.
What does minimatch provide that cannot be achieved with glob?
The thing with glob vs minimatch is that glob seems to be much better mantained and used.
There was a problem hiding this comment.
minimatch is used in glob https://github.com/isaacs/node-glob/blob/master/package.json#L23 and both libraries belongs to the same maintainer too
ref #901 #341 #469