Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix high cpu load problem + apply flake8 rules + fix is syntax #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devprofile98
Copy link

@devprofile98 devprofile98 commented Dec 4, 2021

1 - using pass in while when checking for ready on line 115 causes high CPU load, something around 100% CPU use, a small sleep will release CPU clocks for good use.
2 - use of is for comparing two number in python is wrong and == should be replaced.
3 - flake8 rules applied to make python code more readable and clean

@tatobari
Copy link
Owner

tatobari commented Dec 13, 2021

Hi! Thanks for the PR. I'll check it out by the end of the week. I'll also submit a whole new version based on interrupts instead of a loop that waits, in order to avoid freezing the CPU while waiting for the data line to go LOW, so I'll pull this into the new version as well.

@devprofile98
Copy link
Author

devprofile98 commented Dec 13, 2021 via email

@AddisonG
Copy link

Still waiting on this

AddisonG added a commit to AddisonG/timtamcam that referenced this pull request Aug 18, 2023
@devprofile98
Copy link
Author

Hi, I am here again after about 3 years, do you have any plans about this pull request? or should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants