Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IPC on multiwindowed linux apps (fix #11171) #11236

Closed
wants to merge 3 commits into from

Conversation

Ynng
Copy link

@Ynng Ynng commented Oct 5, 2024

closes #11171

  • Fix ipc on multiwindowed linux apps
  • Include window label in InvokeRequest
  • Update the IPC handler to fetch webview based on the window label in InvokeRequest

@Ynng Ynng requested a review from a team as a code owner October 5, 2024 20:12
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Package Changes Through 0e048e3

There are 4 changes which include @tauri-apps/api with patch, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.0.1 2.0.2
tauri-bundler 2.0.1 2.0.2
@tauri-apps/cli 2.0.1 2.0.2
tauri-cli 2.0.1 2.0.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member

@Ynng thanks for investigating and making a PR, I wonder if we can fix this in wry instead.

@Ynng
Copy link
Author

Ynng commented Oct 5, 2024

@Ynng thanks for investigating and making a PR, I wonder if we can fix this in wry instead.

As in fixing the underlying "Cannot register URI scheme xxx more than once"?

@amrbashir
Copy link
Member

amrbashir commented Oct 8, 2024

thanks @Ynng, I have decided to incorporate the idea of this PR in wry instead, see tauri-apps/wry#1384 and #11268. Apologies for the inconvenience.

@lucasfernog maybe we should merge this as a fix for 2.0.0 because #11268 will require a minor bump.

Comment on lines +135 to +136
/// The label of the webview that requested this command.
pub label: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are gonna merge this PR as temporary fix, we should avoid adding this field.

let label = parts
.headers
.get(TAURI_WEBVIEW_LABEL_HEADER_NAME)
.ok_or("missing Tauri-Webview-Label header")?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also fix tests that are failing because of this?

@Ynng
Copy link
Author

Ynng commented Oct 8, 2024

Thanks @amrbashir for the proper fix in wry (tauri-apps/wry#1384 and #11268)!

Given that this PR introduces temporary changes across multiple files and a new field in InvokeRequest, I'm okay with closing it in favor of waiting for the wry-based solution.

@amrbashir
Copy link
Member

@Ynng This PR can still be merged to fix the current released minor, we just need the changes I requested

@amrbashir
Copy link
Member

amrbashir commented Oct 12, 2024

thanks @Ynng , I will go ahead and close this then since #11268 will be merged and released as patch

@amrbashir amrbashir closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] broken IPC in multi window app on Linux
2 participants