fix(deps): Downgrade minisign to 0.7.3 again #8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for merging, as i upgrade tauri from 1.4 to 1.5 yesterday and now i can't build my project with empty password... |
lucasfernog
approved these changes
Oct 23, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-minisign was upgraded to 0.7.5 in the last patch release via #7641 even though it was pinned. It was downgraded because 0.7.5 breaks the update bundle signer if an empty password is provided, see FabianLars/mw-toolbox#550 (pr that made me notice the change) and jedisct1/rust-minisign#26 (upstream issue i opened) and #7197 (the last time i downgraded it)
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information