Fix test failures (#300)

* Fix upload artifact * Fix STDIN with large inputs
taybenlor · Nov 17, 2024 · b252dba · b252dba
1 parent 2abdc7c
commit b252dba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/test-on-pull-request.yml b/.github/workflows/test-on-pull-request.yml
@@ -18,7 +18,7 @@ jobs:
         run: npm run test
       - name: Upload test results
         if: always()
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: playwright-report
           path: playwright-report
diff --git a/packages/wasi/tests/libstd.spec.ts b/packages/wasi/tests/libstd.spec.ts
@@ -57,6 +57,7 @@ for (const name of wasmFiles) {
 
           let stderr = "";
           let stdout = "";
+          let stdinBytes = new TextEncoder().encode(stdin ?? "");
 
           return W.start(
             fetch(url),
@@ -69,11 +70,10 @@ for (const name of wasmFiles) {
               stderr: (s) => {
                 stderr += s;
               },
-              stdin: (maxByteLength: number) => {
-                const index = Math.floor(maxByteLength / 2) + 1;
-                const retvalue = stdin.slice(0, index);
-                stdin = stdin.slice(index);
-                return retvalue;
+              stdin: (maxByteLength) => {
+                const chunk = stdinBytes.slice(0, maxByteLength);
+                stdinBytes = stdinBytes.slice(maxByteLength);
+                return new TextDecoder().decode(chunk);
               },
               fs,
             })