fix removing attributes during hydration (sveltejs#1733)

taylorzane · Dec 17, 2020 · 3b4a477 · 3b4a477
1 parent 7325c10
commit 3b4a477
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/runtime/internal/dom.ts b/src/runtime/internal/dom.ts
@@ -152,11 +152,16 @@ export function claim_element(nodes, name, attributes, svg) {
 	for (let i = 0; i < nodes.length; i += 1) {
 		const node = nodes[i];
 		if (node.nodeName === name) {
-			for (let j = 0; j < node.attributes.length; j += 1) {
+			let j = 0;
+			while (j < node.attributes.length) {
 				const attribute = node.attributes[j];
-				if (!attributes[attribute.name]) node.removeAttribute(attribute.name);
+				if (attributes[attribute.name]) {
+					j++;
+				} else {
+					node.removeAttribute(attribute.name);
+				}
 			}
-			return nodes.splice(i, 1)[0]; // TODO strip unwanted attributes
+			return nodes.splice(i, 1)[0];
 		}
 	}